Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve types in Greater/Lesser Expectations #716

Merged
merged 3 commits into from Mar 21, 2023
Merged

Improve types in Greater/Lesser Expectations #716

merged 3 commits into from Mar 21, 2023

Conversation

dansysanalyst
Copy link
Collaborator

Q A
Bug fix? yes
New feature? no
Fixed tickets #713

This PR adds DateTimeand DateTimeImmutableto the following expectations:

  • toBeGreaterThan
  • toBeGreaterThanOrEqual
  • toBeLessThan
  • toBeLessThanOrEqual

owenvoke
owenvoke approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍🏻 But why not mixed to match PHPUnit? 🤔 I get the stricter typing, but 🤷🏻

@nunomaduro nunomaduro merged commit 9a41f2f into pestphp:2.x Mar 21, 2023
@fabio-ivona fabio-ivona mentioned this pull request Mar 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenvoke owenvoke owenvoke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dansysanalyst @owenvoke @nunomaduro