TestSuiteLoader will always consider classes from the current file #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to have test classes which extend from other test classes. This allows for a set of test cases to run in the parent class, then the child class can override certain methods, and have the same test cases run.
This works with PHPUnit 10, but when running the same tests via Pest, some of the parent classes are ignored. This happens because of changes in the override to
TestSuiteLoader. Once a class is loaded, it's not considered again, so if the child class is loaded before the parent, the parent will never be considered for test cases.This PR is an attempt to resolve this, but I'd would also like to ask if there is any reason this should not be allowed?