Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for non-constant parameter overrides in condition table #90

Closed
dweindl opened this issue Apr 2, 2019 · 3 comments
Closed

Add support for non-constant parameter overrides in condition table #90

dweindl opened this issue Apr 2, 2019 · 3 comments
Assignees
@dweindl
Labels
enhancement New feature or request

Comments

@dweindl
Copy link
Member

dweindl commented Apr 2, 2019

Need to adapt optimization to simulation parameter mapping (core.get_optimization_to_simulation_parameter_mapping). What else?
@dweindl dweindl added enhancement New feature or request pythonlib labels Apr 2, 2019
@dweindl dweindl mentioned this issue Apr 2, 2019
Closed
5 tasks
@dweindl dweindl self-assigned this Apr 2, 2019
@yannikschaelte
Copy link
Member

Probably also account for scale of parameter according to core.get_optimization_to_simulation_scale_mapping?

@dweindl
Copy link
Member Author

dweindl commented Apr 2, 2019

Good point, thanks. Will only allow overrides with same scale for a start.

dweindl added a commit that referenced this issue Apr 2, 2019
@dweindl
Allow for condition-specific overrides of dynamic parameters (Closes #90
ed4639a 
)

- Remove duplicate functions
- Remove non-standard handling of constant parameters
- Replace fixed parameter names by nominal values during mapping
- Check override parameter scale where possible
@dweindl dweindl mentioned this issue Apr 2, 2019
Merged
@dweindl
Copy link
Member Author

dweindl commented Apr 4, 2019

TODO: petab.core.create_parameter_df still needs to be adapted

@dweindl dweindl closed this as completed in fe3f146 Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dweindl @yannikschaelte