Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Bug: Initial tags created by IZipkinSpanBuilder aren't actually passed to span #25

Closed
Aaronontheweb opened this issue Apr 23, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@Aaronontheweb
Copy link
Member

Found this out during some integration testing; looks like we never actually pass this collection into the Span constructor anywhere:

https://github.com/petabridge/Petabridge.Tracing.Zipkin/blob/dev/src/Petabridge.Tracing.Zipkin/SpanBuilder.cs#L104

@Aaronontheweb Aaronontheweb added the bug Something isn't working label Apr 23, 2018
Aaronontheweb added a commit to Aaronontheweb/Petabridge.Tracing.Zipkin that referenced this issue Apr 23, 2018
Aaronontheweb added a commit to Aaronontheweb/Petabridge.Tracing.Zipkin that referenced this issue Apr 23, 2018
This was referenced Apr 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant