Use 'return -code error ...' instead of 'error ...' #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xdnd::GetDroppedData
useserror
to report back an exceptional situation: there's no common DND data type; this situation also occurs when dragging some object over a non-DND-aware widget within a Tk application => thiserror
statement is called often in a normal application.xdnd::GetDroppedData
is used viaxdnd::GetPositionData
in acatch
block withinxdnd::HandleXdndPosition
.If your application uses a custom error handler by redefining
error
, thoseerror
calls end up in the custom error handler, although these are not really error situations, but normal behaviour.=> It would be better to use
return -code error ...
in this case.