Added tests for STDIN, and fix the STDIN reading along the way

Next.pm

@@ -84,7 +84,8 @@ whatever.
 =head2 from_file( [ \%options, ] $filename )
 
 Returns an iterator that iterates over each of the files specified
-in I<$filename>.  If I<$filename> is C<->, then STDIN is opened.
+in I<$filename>.  If I<$filename> is C<->, then the files are read
+from STDIN.
 
 The files are assumed to be in the file one filename per line.  If
 I<$null_separated> is passed, then the files are assumed to be
@@ -331,9 +332,15 @@ sub from_file {
         $err->( 'Must pass a filename to from_file()' );
     }
 
-    open( my $fh, '<', $filename );
-    if ( !$fh ) {
-        $err->( "Unable to open $filename: $!" );
+    my $fh;
+    if ( $filename eq '-' ) {
+        $fh = \*STDIN;
+    }
+    else {
+        open( $fh, '<', $filename );
+        if ( !$fh ) {
+            $err->( "Unable to open $filename: $!" );
+        }
     }
     my $filter = $parms->{file_filter};
 

t/Util.pm

@@ -1,5 +1,7 @@
 package main;
 
+use File::Next;
+
 sub slurp {
     my $iter = shift;
     my @files;

t/dot.t

@@ -27,13 +27,15 @@ NO_PARMS: {
         filelist-nul.txt
         follow.t
         from_file.t
+        from_stdin.t
         give-me-a-process-pipe.pl
         methods.t
         parms.t
         pod-coverage.t
         pod.t
         process-substitution.t
         sort.t
+        stdin-iterator.pl
         Util.pm
         zero.t
         swamp/a/a1

t/everything.t

@@ -28,13 +28,15 @@ NO_PARMS: {
         t/filelist-nul.txt
         t/follow.t
         t/from_file.t
+        t/from_stdin.t
         t/give-me-a-process-pipe.pl
         t/methods.t
         t/parms.t
         t/pod-coverage.t
         t/pod.t
         t/process-substitution.t
         t/sort.t
+        t/stdin-iterator.pl
         t/swamp
         t/swamp/0
         t/swamp/a

t/filelist.txt

@@ -12,4 +12,5 @@ t/pod-coverage.t
 t/pod.t
 t/process-substitution.t
 t/sort.t
+t/swamp/perl-test.t
 t/zero.t

t/from_file.t

@@ -12,28 +12,31 @@ use File::Next;
 # use Test::Differences;
 # eq_or_diff \@got, [qw( a b c )], "testing arrays";
 
+my @expected = qw(
+    t/00-load.t
+    t/api.t
+    t/basic.t
+    t/dirs.t
+    t/dot.t
+    t/everything.t
+    t/follow.t
+    t/from_file.t
+    t/methods.t
+    t/parms.t
+    t/pod-coverage.t
+    t/pod.t
+    t/process-substitution.t
+    t/sort.t
+    t/swamp/perl-test.t
+    t/zero.t
+);
+
+
 FROM_FILESYSTEM_FILE: {
     my $iter = File::Next::from_file( 't/filelist.txt' );
     isa_ok( $iter, 'CODE' );
 
     my @actual = slurp( $iter );
-    my @expected = qw(
-        t/00-load.t
-        t/api.t
-        t/basic.t
-        t/dirs.t
-        t/dot.t
-        t/everything.t
-        t/follow.t
-        t/from_file.t
-        t/methods.t
-        t/parms.t
-        t/pod-coverage.t
-        t/pod.t
-        t/process-substitution.t
-        t/sort.t
-        t/zero.t
-    );
     sets_match( \@actual, \@expected, 'FROM_FILESYSTEM_FILE' );
 }
 
@@ -43,23 +46,5 @@ FROM_NUL_FILE: {
     isa_ok( $iter, 'CODE' );
 
     my @actual = slurp( $iter );
-    my @expected = qw(
-        t/00-load.t
-        t/api.t
-        t/basic.t
-        t/dirs.t
-        t/dot.t
-        t/everything.t
-        t/follow.t
-        t/from_file.t
-        t/methods.t
-        t/parms.t
-        t/pod-coverage.t
-        t/pod.t
-        t/process-substitution.t
-        t/sort.t
-        t/swamp/perl-test.t
-        t/zero.t
-    );
     sets_match( \@actual, \@expected, 'FROM_NUL_FILE' );
 }

t/from_stdin.t

@@ -0,0 +1,43 @@
+#!perl
+
+use strict;
+use warnings;
+use Test::More tests => 2;
+
+use lib 't';
+use Util;
+
+my $CAT = "$^X -pe1";
+
+my @expected = qw(
+    t/00-load.t
+    t/api.t
+    t/basic.t
+    t/dirs.t
+    t/dot.t
+    t/everything.t
+    t/follow.t
+    t/from_file.t
+    t/methods.t
+    t/parms.t
+    t/pod-coverage.t
+    t/pod.t
+    t/process-substitution.t
+    t/sort.t
+    t/swamp/perl-test.t
+    t/zero.t
+);
+
+FROM_STDIN: {
+    # Pipe stuff into the iterator
+    my @actual = `$CAT t/filelist.txt | $^X -Mblib t/stdin-iterator.pl`;
+    chomp @actual;
+    sets_match( \@actual, \@expected, 'FROM_STDIN' );
+}
+
+FROM_STDIN_NUL: {
+    # Pipe nul-separated stuff into the iterator that handles nul-separated
+    my @actual = `$CAT t/filelist-nul.txt | $^X -Mblib t/stdin-iterator.pl 1`;
+    chomp @actual;
+    sets_match( \@actual, \@expected, 'FROM_STDIN_NUL' );
+}

t/stdin-iterator.pl

@@ -0,0 +1,13 @@
+#!/usr/bin/env perl
+
+use strict;
+use warnings;
+
+use File::Next;
+
+my $nul = shift;
+
+my $iter = File::Next::from_file( { nul_separated => $nul }, '-' );
+while ( my $file = $iter->() ) {
+    print "$file\n";
+}