check the return value of the open

petdance · Jun 12, 2012 · f0ea864 · f0ea864
1 parent 191a72c
commit f0ea864
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/t/first-and-last-lines-via-process-pipe.pl b/t/first-and-last-lines-via-process-pipe.pl
@@ -9,8 +9,7 @@
 
 my $files = File::Next::files( $input );
 my $file  = $files->();
-open my $f, '<', $file if defined $file;
+if ( open my $f, '<', $file ) {
-if ( $f ) {
     my @lines = <$f>;
     print $lines[0];
     print $lines[-1];