Add functions to C library wrapper #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebachant
reviewed
Sep 3, 2023
acspy/acsc.py
Outdated
| @@ -277,27 +300,20 @@ def toPointM(hcomm, flags, axes, target, wait=SYNCHRONOUS): | |||
| call_acsc(acs.acsc_ToPointM, hcomm, flags, axes_c, target_c, wait) | |||
|
|
|||
|
|
|||
| def enable(hcomm, axis, wait=SYNCHRONOUS): | |||
| def enableMotor(hcomm, axis:int, wait=SYNCHRONOUS): | |||
There was a problem hiding this comment.
We shouldn't rename this in case others are depending on it (like some of my apps!) You can create an alias if you'd like, but I've just been mirroring the ACS function names, which here is just enable.
There was a problem hiding this comment.
Hi Pete, ok! On it. Thanks for your answer.
petebachant
reviewed
Sep 3, 2023
petebachant
requested changes
Sep 3, 2023
There was a problem hiding this comment.
Thanks for the contribution! A couple things:
- Existing APIs should be left in place, following the "open/closed principle" (open for extension, closed for change). You can add new functions, but don't delete or change existing ones in ways that could break any code depending on this library.
- Please run
black -l79on the code. I should automate that with GitHub Actions, but haven't got around to it yet.
|
Hi Pete, great. Thanks for the explanation. I'm going to fix this to follow the open/closed principle then. |
petebachant
reviewed
Sep 11, 2023
acspy/acsc.py
Outdated
| @@ -192,6 +192,11 @@ def setJerk(hcomm, axis: int, jerk: double, wait=SYNCHRONOUS): | |||
| call_acsc(acs.acsc_SetJerk, hcomm, axis, double(jerk), wait) | |||
|
|
|||
|
|
|||
| def setRPosition(hcomm, axis: int, rpos: double, wait=SYNCHRONOUS): | |||
There was a problem hiding this comment.
The type hints for these should be Python types, since we convert to ctypes internally
Suggested change
| def setRPosition(hcomm, axis: int, rpos: double, wait=SYNCHRONOUS): | |
| def setRPosition(hcomm, axis: int, rpos: float, wait=SYNCHRONOUS): |
petebachant
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Pete, I'm interested in contributing to your repo. Here are a couple of functions. I would like to check with you if I understood correctly how to wrap them from the C API. Thanks in advance.