Skip to content

Commit

Permalink
Revert "test(compiler-cli): ensure reflection tests are not brittle t…
Browse files Browse the repository at this point in the history
…o case-sensitivity (angular#36968)"

This reverts commit dcf1dcb.

The changes to the case-sensitivity handling in angular#36968 caused multiple
projects to fail to build. See angular#36992, angular#36993 and angular#37000.

The issue is related to the logical path handling. But it is felt that
it is safer to revert the entire PR and then to investigate further.
  • Loading branch information
petebacondarwin committed May 8, 2020
1 parent d1b3af6 commit 7341279
Showing 1 changed file with 3 additions and 3 deletions.
Expand Up @@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/
import * as ts from 'typescript';
import {absoluteFrom, getSourceFileOrError} from '../../file_system';
import {absoluteFrom} from '../../file_system';
import {runInEachFileSystem} from '../../file_system/testing';
import {getDeclaration, makeProgram} from '../../testing';
import {CtorParameter} from '../src/host';
Expand Down Expand Up @@ -329,8 +329,8 @@ runInEachFileSystem(() => {
} else if (directTargetDecl === null) {
return fail('No declaration found for DirectTarget');
}
expect(targetDecl.node!.getSourceFile())
.toBe(getSourceFileOrError(program, _('/node_modules/absolute/index.ts')));
expect(targetDecl.node!.getSourceFile().fileName)
.toBe(_('/node_modules/absolute/index.ts'));
expect(ts.isClassDeclaration(targetDecl.node!)).toBe(true);
expect(directTargetDecl.viaModule).toBe('absolute');
expect(directTargetDecl.node).toBe(targetDecl.node);
Expand Down

0 comments on commit 7341279

Please sign in to comment.