[Major Changes][Sprockets 3] Supporting multiple sprockets versions and using versionized classes.

[bogdanRada]

Hello , as discussed here: #38 i made the changes for using different classes for different versions.

Tilt dependency is still removed, but if you want to keep it for the legacy versions , let me know and i can rewrite the V2 class for SASS template.

All tests are passing. for botth sprockets 2.x and 3.x, however sprockets 4 is not support yet, becasue i need to fix the importer for that version

Also fixed all issues i could find with Rubocop.

THIS WILL ALSO DROP Ruby 1.9

Let me know if this is better now :)

[bogdanRada]

Of course, some more cleaning can be done,if needed. Let me know if you want to refactor something or change anything. Thanks

[bogdanRada]

I think we should also update the Sprockets::Sass::V3::Functions to be the same as the ones from Sprockets-herlpers, some of them were changed to require two parameters for sprockets 3, But i am not sure if we need to keep compatibility with that gem too. Currently the tests are passing because our functions are included after the Sprockets::Helpers so we are overriding them.

This functions will need to get refactored though for sprockets 4, becauase context.logical_path is now throwing NoMethodError.

Just wanted to know if we want to keep that compatibility or not.

Or we can drop our functions for sprockets >= 3 and rely only on sprockets-helpers. Let me know what you decide. Thanks

Actually i think this is intended, seems same thing happens with sprockets 2.x. Nevermind about this :)

[petebrowne]

Shouldn't this only require the the libraries for the current version of sprockets? If we're requiring all of them, we could just explicitly list the require statements

[bogdanRada]

Usually yes, but considering for example for sprockets 4....from the list of files only three of them are currently defined for that version....the other ones will be used from v3...since no changes are there.

[bogdanRada]

I updated the code as you suggested, all tests are passsing, I am still working on V4 Importer.

[bogdanRada]

I improved a bit the v4 importer....now only 9 failures are there...but i am still working on the other failures. The other tests for sprockets 2.x and 3.x are still passing. https://travis-ci.org/bogdanRada/sprockets-sass/builds/154435384

Edited: This is the latest build https://travis-ci.org/bogdanRada/sprockets-sass/builds/154467954 and now are only 6 failures for sprockets 4.x

[bogdanRada]

I hope now is better, I can rebase and squash the commits if you approve the changes. Let me know if i need to change something else . THanks

[petebrowne]

Thanks, this is really great. What's left todo?

• sprockets-helpers compatibility
• sprockets 4 compatibility

^ Both of these could be separate PRs

[bogdanRada]

Yes, i agree, and some real life testing on applications, to see if this is working as expected.

I rebased the commits and squashed them into a single commit.

Also i have a question, seems that in newer versions of sass , is possible to use render_with_sourcemap from the Sass::Engine class. Do you need some support for rendering with Sourcemap also?
That can be done in a separate PR also if needed.

Let me know if something else is needed from this PR, refactoring something or changing anything. Thank you very much for your support.

[bogdanRada]

I tested with older version of sprockets 2.12 and some other versions (2.x) , they seem to work fine. However i don't have an application with Sprockets 3.7 ready . I can try and test with latest version also but will need some time to prepare an application for that if is necessary.

[petebrowne]

👍 Merging this in - I'm planning to release this as 2.0.0.beta1 so we can have people test it out in real world applications while we iron out some of the other details.

[bogdanRada]

Wow....thanks very much :) This is awesome :D