Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: allow push-to-fork to push to sibling repos #2414

Merged
merged 1 commit into from Sep 29, 2023
Merged

Conversation

bgilbert
Copy link
Contributor

Fixes #2412.

@peter-evans
Copy link
Owner

peter-evans commented Sep 29, 2023

/testv5 repository=bgilbert/create-pull-request ref=network build=true

Command run output

@peter-evans
Copy link
Owner

Hi @bgilbert

Thank you for contributing!

It makes sense to me that push-to-fork should allow the base repo to be a sibling of the fork, and not require it to be its parent. 👍

I'm going to add a test to my test suite to verify that it works before merging.

@peter-evans
Copy link
Owner

Added a test to the suite and it works fine 🎉

peter-evans/create-pull-request-tests@283f60e

Creates a PR in the sibling repo: create-pull-request/create-pull-request-tests#1

@peter-evans
Copy link
Owner

I'm going to be releasing a new major version of the action soon so I'm thinking I will just include this change with that. So I'll merge this to a feature branch and make it available as a release candidate for v6.

@peter-evans peter-evans changed the base branch from main to push-to-fork-with-sibling-base September 29, 2023 15:23
@peter-evans peter-evans merged commit bba68d5 into peter-evans:push-to-fork-with-sibling-base Sep 29, 2023
5 checks passed
@bgilbert bgilbert deleted the network branch September 29, 2023 20:57
peter-evans added a commit that referenced this pull request Jan 31, 2024
* feat: update author and committer input defaults

* Update github-actions[bot]

* Update author to new email format

* feat: optional input for git ops token

* feat: allow push-to-fork to push to sibling repos (#2414)

Fixes #2412.

* build: update dist

* feat: update action runtime to node 20 (#2340)

* feat: add truncate warning to pull request body

* perf: unshallow only when necessary

* fix: remove the remote for the fork on completion

* feat: infer github server and api urls

* test: integration test fixes

* build: bump major version

* docs: update to v6

---------

Co-authored-by: Teko <112829523+Teko012@users.noreply.github.com>
Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
peter-evans added a commit that referenced this pull request Jan 31, 2024
* feat: update author and committer input defaults

* Update github-actions[bot]

* Update author to new email format

* feat: optional input for git ops token

* feat: allow push-to-fork to push to sibling repos (#2414)

Fixes #2412.

* build: update dist

* feat: update action runtime to node 20 (#2340)

* feat: add truncate warning to pull request body

* perf: unshallow only when necessary

* fix: remove the remote for the fork on completion

* feat: infer github server and api urls

* test: integration test fixes

* build: bump major version

* docs: update to v6

---------

Co-authored-by: Teko <112829523+Teko012@users.noreply.github.com>
Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
aleksandrychev pushed a commit to aleksandrychev/create-pull-request that referenced this pull request Mar 4, 2024
* feat: update author and committer input defaults

* Update github-actions[bot]

* Update author to new email format

* feat: optional input for git ops token

* feat: allow push-to-fork to push to sibling repos (peter-evans#2414)

Fixes peter-evans#2412.

* build: update dist

* feat: update action runtime to node 20 (peter-evans#2340)

* feat: add truncate warning to pull request body

* perf: unshallow only when necessary

* fix: remove the remote for the fork on completion

* feat: infer github server and api urls

* test: integration test fixes

* build: bump major version

* docs: update to v6

---------

Co-authored-by: Teko <112829523+Teko012@users.noreply.github.com>
Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

push-to-fork won't push to sibling repos in the same network
2 participants