Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to dotnet 4.8 and use PackageReference instead of packages.config #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alireza-delavari
Copy link
Contributor

I used "UnmanagedExports.Repack.Upgrade" package instead of "UnmanagedExports".
if build failed, remove bin and obj folders.

@peter-frentrup
Copy link
Owner

Hello,
thank you for your time an effort. However, I am reluctant to the proposed change of the target framework:
Why is a change to .Net Framework 4.8 necessary? What is the benefit for the user? 4.0 should be compatible with 4.8, so the plugin should be able to run on a PC with only 4.8 installed.

Your fix for x64 is worth looking into. But that class "ClikeStringArray" does not seem to be used at all. So maybe I should just delete it...

Best regards,
Peter

@alireza-delavari
Copy link
Contributor Author

Hello and thank you for your time.
I am using visual studio 2022 and when I opened this project, it suggest to upgrade to .Net Framework 4.8 .
I tried installing .Net Framework 4.0 but accoring to the note at end of this page , we can't load .Net Framework 4.0 projects to newer versions of Visual Studio.

I used "ClikeStringArray" class in this #40 pull request, I also applied that x64 fix to that pull request again so this two pull requests doesn't have dependency with each other.

@peter-frentrup
Copy link
Owner

That's a shame. The link you mention suggests that the problem is due to your other change to "UnmanagedExports.Repack.Upgrade" instead of "UnmanagedExports". Staying with "UnmanagedExports" allows to keep "packages.config".

@Gitoffthelawn
Copy link

I agree that .Net Framework 4.8 is undesirable unless truly needed. There are many offline systems that use Notepad++ that do not have .Net Framework 4.8 installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants