Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full() API and tests #194

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

brendan-simon-indt
Copy link
Contributor

Adds a full() API to complement the empty() API.

The full() API is available in Python3 queue.Queue class and this PR makes persist-queue more consistent with the queue.Queue API.

There doesn't seem to be a notion of a full queue when using database queues. The full() API is provided for consistency and always returns False.

Copy link
Owner

@peter-wangxu peter-wangxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@peter-wangxu peter-wangxu merged commit f3f3682 into peter-wangxu:master Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants