Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for python2 #201

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Remove support for python2 #201

merged 5 commits into from
Feb 13, 2024

Conversation

peter-wangxu
Copy link
Owner

@peter-wangxu peter-wangxu commented Feb 8, 2024

1.0.0-alpha

  1. Only Python3.x series are offically supported by persistqueue, since Python 2 was no longer under maintenance since 2020

  2. persistqueue.Queue using serializer=persistqueue.serializers.pickle created under python2 was no longer able to be read by persist queue after 1.0.0
    as the default pickle version changed from 2 to 4

@peter-wangxu peter-wangxu force-pushed the use_python3 branch 2 times, most recently from 3e9e896 to b4594c3 Compare February 8, 2024 07:56
@peter-wangxu peter-wangxu changed the title use python3 type hints Remove support for python2 Feb 8, 2024
@peter-wangxu peter-wangxu force-pushed the use_python3 branch 8 times, most recently from ffbfd78 to 5021d01 Compare February 9, 2024 12:40
@peter-wangxu peter-wangxu force-pushed the use_python3 branch 3 times, most recently from bc1aabf to 8868436 Compare February 11, 2024 12:12
Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (74f464a) 93.65% compared to head (d58f253) 95.04%.

Files Patch % Lines
persistqueue/serializers/msgpack.py 77.77% 0 Missing and 2 partials ⚠️
persistqueue/mysqlqueue.py 94.11% 1 Missing ⚠️
persistqueue/queue.py 96.96% 1 Missing ⚠️
persistqueue/serializers/pickle.py 91.66% 0 Missing and 1 partial ⚠️
persistqueue/sqlackqueue.py 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   93.65%   95.04%   +1.38%     
==========================================
  Files          18       17       -1     
  Lines        2208     2178      -30     
  Branches      230      224       -6     
==========================================
+ Hits         2068     2070       +2     
+ Misses         89       60      -29     
+ Partials       51       48       -3     
Flag Coverage Δ
python 95.04% <96.79%> (+1.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peter-wangxu peter-wangxu merged commit cd2aa37 into master Feb 13, 2024
15 checks passed
@peter-wangxu peter-wangxu deleted the use_python3 branch February 13, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant