-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent clashing of function names in different modules #41
Conversation
Try using If I remember correctly, it was brought up here: #15 |
Nice, I haven't read that issue and I thought Python2.7 support was required. Even better. I have changed that and fixed the tests. |
Seems you just have a linting error. |
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 41 41
=========================================
Hits 41 41
Continue to review full report at Codecov.
|
Should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Should be in 0.1.7 now https://pypi.org/project/django-cache-memoize/0.1.7/ |
Awesome, thanks @peterbe ! 👏 |
Fixes #15
Hi @peterbe,
First of all I would like to thank you for your awesome library.
I found some problem using it in a project not so small, that some modules can have same function name and it's very tedious to set
prefix
all the time.What do you think of the solution I propose using
__module__
(I know the tests are not passing)? I think that would fix a lot of cases, even if some would still remain (for example, objects with the same function name or inherited in the same module)Kind regards and thank you for your work