Be kinder if the package is a requirements file #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythmon
approved these changes
Mar 6, 2019
| and args.packages | ||
| and len(args.packages) == 1 | ||
| and os.path.isfile(args.packages[0]) | ||
| and args.packages[0].endswith(".txt") |
There was a problem hiding this comment.
I think it would a small improvement to re-arrange these so that the file existence check happens last, since that is going to be the most expensive one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104
@mythmon r?
It's a small and conservative change. I've been bitten by it so many times when running
hashin -u -i requirements/default.txtand it essentially complaining at me when it assumes thatrequirements/default.txtis the name of a python package.