Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make url metadata parsing compatible with new PyPI URLs #17

Merged
merged 1 commit into from Apr 28, 2016

Conversation

mythmon
Copy link
Contributor

@mythmon mythmon commented Apr 27, 2016

PyPI has added a new kind of URL, using the hash of the file as the directory path instead of a path based on the Python version and the package name. Luckily, we weren't using that information. I changed the URL analyzers to ignore the path in the URL, and only look at the filename. This should be more robust in the future: The filenames are standardized, the path is not.

@peterbe r?

@peterbe
Copy link
Owner

peterbe commented Apr 27, 2016

I trust your code change but I think I ought to try it manually. How can I attempt to do it so it doesn't work using a local virtualenv and then verify that using your patch, instead, it fixes the problem?

@mythmon
Copy link
Contributor Author

mythmon commented Apr 27, 2016

For me, any use of hashin tickles this bug. In particular, I tried running hashin django==1.8.12 -p 3.5 and got a traceback before this patch.

Edit: any use of hashin with the -p flag.

@peterbe
Copy link
Owner

peterbe commented Apr 27, 2016

BUt it has to be with -p ... right? Because I managed to use hashin this morning for a couple of things.

@mythmon
Copy link
Contributor Author

mythmon commented Apr 27, 2016

Er, right. I was using the older version of hashin that parses urls even if you don't filter by Python version.

@peterbe peterbe merged commit 75f8393 into peterbe:master Apr 28, 2016
@peterbe
Copy link
Owner

peterbe commented Apr 28, 2016

I was able to reproduce the error, used your branch and then it worked.

@peterbe
Copy link
Owner

peterbe commented Apr 28, 2016

Version 0.4.2 on its way to PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants