Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop requiring git hooks to lint #144

Closed
peterbe opened this issue Feb 14, 2018 · 0 comments
Closed

Stop requiring git hooks to lint #144

peterbe opened this issue Feb 14, 2018 · 0 comments
Assignees

Comments

@peterbe
Copy link
Owner

peterbe commented Feb 14, 2018

99% of the time I use Atom. Atom has great "bindings" with Prettier so you can configure it to Prettier format upon file save. That's what the current lint git pre-commit hooks currently.
The advantage with doing it in the IDE is that you see what changes right away.

The other few times (or any other contributor) uses a non-IDE with prettier integration, the lintcheck in travis is there to prevent PRs being made that don't conform.

For those reasons, let's drop the lint-staged script hook.

@peterbe peterbe self-assigned this Feb 14, 2018
peterbe added a commit that referenced this issue Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant