Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use some-kind of type validator #21

Closed
stereobooster opened this issue Oct 21, 2017 · 4 comments
Closed

Use some-kind of type validator #21

stereobooster opened this issue Oct 21, 2017 · 4 comments

Comments

@stereobooster
Copy link
Collaborator

For example puppeteer uses TypeScript to validate code based on jsdoc annotations puppeteer/puppeteer#986

Also flow can do some validation, but not sure if there is puppeteer type definitions.

@peterbe
Copy link
Owner

peterbe commented Oct 23, 2017

Are you suggesting that we rewrite it in TypeScript? I wouldn't mind.

@peterbe
Copy link
Owner

peterbe commented Oct 23, 2017

Worth thinking about the fact the minimalcss isn't much of a lib. It's just an elaborate script around something much more powerful.

@stereobooster
Copy link
Collaborator Author

We can use TypeScript for checking types in JS files.

Worth thinking about the fact the minimalcss isn't much of a lib

Exactly. It is very hard to write unit tests, only integration tests make sense. But with type checker we can verify that we avoid some class of errors without huge test cases.

@peterbe
Copy link
Owner

peterbe commented Oct 23, 2017

Sure. I'm up for it. I've never actually used TypeScript and I'm eager to try it. Will you lead the way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants