Use Typescript to lint JSDoc annotations #986
Conversation
| @@ -116,7 +116,7 @@ class NetworkManager extends EventEmitter { | |||
| response = 'ProvideCredentials'; | |||
| this._attemptedAuthentications.add(event.interceptionId); | |||
| } | |||
| const {username, password} = this._credentials || {}; | |||
| const {username, password} = this._credentials || {username: undefined, password: undefined}; | |||
There was a problem hiding this comment.
is this necessary now?
There was a problem hiding this comment.
Yes. I think it will help more than hurt.
npm-debug.log
Outdated
| @@ -0,0 +1,48 @@ | |||
| 0 info it worked if it ends with ok | |||
There was a problem hiding this comment.
I don't think we want to check in npm-debug.log?
JoelEinbinder
force-pushed
the
typescript
branch
from
a7271d3
to
ce59439
Compare
|
Awwwwsome. Could you please minimize the diff (there are a lot of unnecessary changes like "!" added/removed). And it's good to go. Also, npm-debug is not needed. |
| this._map = new Map(); | ||
| } | ||
|
|
||
| /** | ||
| * @param {K} key | ||
| * @param {V} value |
There was a problem hiding this comment.
@JoelEinbinder just curious... TSC didn't need these annotations? And how did you know they were unnecessary ?
There was a problem hiding this comment.
It’s a bug in typescript. microsoft/TypeScript#18135
|
As soon as annotations are "compatible" with typescript it should be easy to generate TS definitions from JSDoc with something like this: |
A re-upload of #219 from my new repository.
#65