Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A way to pass browser instance #35

Closed
stereobooster opened this issue Oct 28, 2017 · 2 comments
Closed

A way to pass browser instance #35

stereobooster opened this issue Oct 28, 2017 · 2 comments

Comments

@stereobooster
Copy link
Collaborator

In react-snap I already have an instance of browser. It would be nice if I can pass it instead of another being initiated by minimalcss. Would you accept PR?
@peterbe
Copy link
Owner

peterbe commented Oct 30, 2017

Sure! So, instead of

const browser = await puppeteer.launch({})

We'd optionally get it from the options object, right?

stereobooster added a commit to stereobooster/minimalcss that referenced this issue Oct 30, 2017
@stereobooster
Fix for peterbe#35
859857f
@stereobooster stereobooster mentioned this issue Oct 31, 2017
Closed
stereobooster added a commit to stereobooster/minimalcss that referenced this issue Nov 1, 2017
@stereobooster
Fix for peterbe#35
74ac233
stereobooster added a commit to stereobooster/minimalcss that referenced this issue Nov 1, 2017
@stereobooster
Fix for peterbe#35
37a1c07
peterbe pushed a commit that referenced this issue Nov 2, 2017
@stereobooster
Fix for #35 (#36)
de6235a
@peterbe
Copy link
Owner

peterbe commented Nov 2, 2017

Strange that the PR didn't automatically close this issue.

@peterbe peterbe closed this as completed Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterbe @stereobooster