fix(compression-webpack-plugin): fix result type

Expand allowed types for result callback to be compatible with patched version: webpack-contrib/compression-webpack-plugin@v5.0.1...v5.0.2 webpack-contrib/compression-webpack-plugin#190 https://github.com/gfx/universal-zopfli-js/blob/master/src/index.ts#L87 /cc @vitoyucepi Thanks! Fixes: DefinitelyTyped#47230
peterblazejewicz · Sep 2, 2020 · 960c6e8 · 960c6e8
1 parent 6e8dd40
commit 960c6e8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/types/compression-webpack-plugin/compression-webpack-plugin-tests.ts b/types/compression-webpack-plugin/compression-webpack-plugin-tests.ts
@@ -58,13 +58,14 @@ const badZlib: Configuration = {
     ]
 };
 
-function customAlgorithm(input: string, options: number, callback: (err: Error, result: Buffer) => void) {
-}
-
 const custom: Configuration = {
     plugins: [
         new CompressionPlugin({
-            algorithm: customAlgorithm,
+            algorithm: (input: string, options: number, callback: (err: Error, result: Buffer) => void) => {},
+            compressionOptions: 5
+        }),
+        new CompressionPlugin({
+            algorithm: (input: string, options: number, callback: (err: Error, result: Uint8Array) => void) => {},
             compressionOptions: 5
         })
     ]

diff --git a/types/compression-webpack-plugin/index.d.ts b/types/compression-webpack-plugin/index.d.ts
@@ -19,7 +19,7 @@ declare class CompressionPlugin<O = any> extends Plugin {
 }
 
 declare namespace CompressionPlugin {
-    type AlgorithmCallback = (error: Error | null, result: Buffer) => void;
+    type AlgorithmCallback = (error: Error | null, result: Uint8Array) => void;
     type Algorithm<O> = (source: string, options: O, callback: AlgorithmCallback) => void;
 
     // NOTE: These are the async compression algorithms on the zlib object.