Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems to have additional requirement #48

Closed
pwillard opened this issue Nov 14, 2016 · 4 comments
Closed

Seems to have additional requirement #48

pwillard opened this issue Nov 14, 2016 · 4 comments
Assignees
Labels

Comments

@pwillard
Copy link

has a win32console (part of PyWIn32) dependency.

@peterbrittain
Copy link
Owner

peterbrittain commented Nov 14, 2016

Thanks for getting in touch... Can you please clarify the issue?

In particular, how did you install asciimatics? If you installed with pip, it should handle this by installing pypiwin32. Otherwise, did you follow the instructions in https://github.com/peterbrittain/asciimatics/blob/master/README.rst:

If you don't use pip or it fails to install them, you can install the dependencies directly using the packages listed in requirements.txt. Additionally, Windows users will need to install pypiwin32.

@pwillard
Copy link
Author

I used pip. But when I try the sample code it says the pypiwin32 was not
installed. (Oddness)

I'm going to give the whole install another attempt

On Mon, Nov 14, 2016 at 5:33 PM, peterbrittain notifications@github.com
wrote:

Thanks for getting in touch... Can you plese clarify the issue?

In particular, how did you install asciimatics? If you installed with pip,
it should handle this by installing pypiwin32. Otherwise, did you follow
the instructions in https://github.com/peterbrittain/asciimatics/
blob/master/README.rst:

If you don't use pip or it fails to install them, you can install the
dependencies directly using the packages listed in requirements.txt.
Additionally, Windows users will need to install pypiwin32.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#48 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADC9INHHDSrZZeerSrDP-fxDFpTbIvzRks5q-OHCgaJpZM4Kxpbs
.

@peterbrittain peterbrittain self-assigned this Nov 15, 2016
@peterbrittain
Copy link
Owner

I have had some issues with pip dependencies in the past because pypiwin32 can only install on Windows and that mechanism is fragile. Looks like it's broken again. Sigh.

Obviously, the workaround is just to pip install pypiwin32 too, but that's rubbish to force users to figure that out for themselves.

I'll have a look at how it's gone wrong this time and see if this solution finally fixes it.

@peterbrittain
Copy link
Owner

Fixed by v1.7.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants