Issues/59 database context #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9-DatabaseContext
…9-DatabaseContext
ghost
marked this pull request as ready for review
ghost
linked an issue
peterchase
approved these changes
Jun 14, 2022
| @@ -1,4 +1,7 @@ | |||
| { | |||
| "ConnectionStrings": { | |||
| "DefaultConnection": "Server=DESKTOP-5ED6RRO\\SQLEXPRESS;Database=Conway;Trusted_Connection=True;MultipleActiveResultSets=true" | |||
There was a problem hiding this comment.
We probably should not commit this string containing details of your machine. We should possibly add another configuration source that is more secure.
There was a problem hiding this comment.
I think, however, as this code is throwaway and your machine and accounts will be removed at the end of the exercise, we can let this slides for now. I will add an Issue to put in a new configuration source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I created a DataContext and added methods to the Controller class to allow getting, creating and deleting of boards.