Support dark theme

[peterdell]

On large monitors, working with a dark theme is mandatory to not overload the eyes. Currently the icons and color schemes in WUDSN no not work correctly when the darf theme is active. Icons need to be reworks to use transparency and probably there need to be two sets of icons and default colors.

[flashjazzcat]

Sounds good. What dark theme is used in the screenshot, though? My installation has light scrollbars to the left and other horrors when I select the dark theme.

[peterdell]

From what I see, there is just one dark theme. The bit strange part is, that when you switch the first time, not all screen elements are updated and it displays a dialog where you can choose to restart. If you do that, everything looks fine. If you don't some elements retain the light skin like in your screen shot and like the window borders in the one below. It would be more reasonable if there was forced restart.

[flashjazzcat]

Yeah, I always restart after changing the theme and the result is as per my screenshot. The Outline and console scroll bars, for example, never go dark. This is on Windows 11.

[Thexder]

Might be wrong on this as I did not use Eclipse for several years. I think there is a plugin or something that makes eclipse go totally dark theme. SWT (the UI behind Eclipse) is using OS widgets. In native Windows those scrollbars are not themable.

[peterdell]

My test machine runs on Windows 10 Home N. I'll test on a Windows 11 machine to see if that has an impact.

[peterdell]

Here's the result of my test on a current vanilla Windows 11 machine with dark mode activated system-wide.

In my eyes it is just fine, except of course for the default text colors in WUDSN. If it looks different on your machine, I suspect there might be theming settings left in your workspace. So maybe cou can try with a clean Workspace folder?

[flashjazzcat]

Looks good, Peter. I'll certainly give this a try. Is there a WUDSN build with the necessary transparent resource icons, if I can get the dark theme to work here?

[peterdell]

From what I see, some icons already had correct transparency (e.g. LABEL) in the past, some didn't (e.g. PROC). If you confirm there is no other major issue with the windows/scrollbars, then the icons are the next thing for me to fix.

[flashjazzcat]

Oh yes: not all icons were affected; only some. Still got the same problem with a fresh workspace, so perhaps I need to try a completely fresh install on the other PC.

[flashjazzcat]

OK: dark scroll bars, etc, working as you demonstrated with a fresh install of a current Eclipse version under Windows 11. Actually defaults to the OS theme on installation as well.

[peterdell]

Icon transparency added for outline etc. with 2bee22a and 05d4edd. Mit term I should redo the icons with scale 2x.

[peterdell]

API reference https://bugs.eclipse.org/bugs/show_bug.cgi?id=546859

[peterdell]

All icons have been converted from GIF with transparency to PNG with alpha-channel. The preferences keys for the syntax highlighting colors have been separated. This way the chosen colors are kept separately for light and dark theme. The title of the group box indicates, if dark theme is active. Default colors have been added also for the dark theme. Additionally, the tooltip of the color now shows the hexadecimal color value, so you can see the exact color code.

[flashjazzcat]

Excellent. Will test this presently.

[peterdell]

TabFolder in preferences is still grey because of the dependency to Bug 566359 - [Dark theme][win32]- TabFolder header not styled which depends on Bug 568112

[peterdell]

The problem that the default foreground text color is the preferences is not considered appears to be general Eclipse issue, too. Reported as eclipse-platform/eclipse.platform.ui#869

[peterdell]

Note: Content assist background is also not yet correct