Issue checkstyle#6606: catch all exceptions during reflection in Abst…

…ractTypeAware
peterdemaeyer · Apr 27, 2019 · cb0ea16 · cb0ea16
1 parent 520978d
commit cb0ea16
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/config/pmd.xml b/config/pmd.xml
@@ -206,12 +206,15 @@
       <!-- Checker: There is no other way to deliver the filename that was under processing.
            See https://github.com/checkstyle/checkstyle/issues/2285
            TranslationCheck: It is better to catch all exceptions since it can throw
-           a runtime exception. -->
+           a runtime exception.
+           AbstractTypeAwareCheck: Exception type is not predictable. -->
       <property name="violationSuppressXPath"
                 value="//ClassOrInterfaceDeclaration[@Image='Checker']
                              //MethodDeclaration[@Name='processFiles']
                       |//ClassOrInterfaceDeclaration[@Image='TranslationCheck']
-                             //MethodDeclaration[@Name='getTranslationKeys']"/>
+                             //MethodDeclaration[@Name='getTranslationKeys']
+                      |//ClassOrInterfaceDeclaration[@Image='AbstractTypeAwareCheck']
+                             //MethodDeclaration[@Name='resolveClass']"/>
     </properties>
   </rule>
   <rule ref="category/java/design.xml/AvoidDeeplyNestedIfStmts">

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractTypeAwareCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractTypeAwareCheck.java
@@ -240,7 +240,8 @@ protected final Class<?> resolveClass(String resolvableClassName,
         try {
             clazz = getClassResolver().resolve(resolvableClassName, className);
         }
-        catch (final ClassNotFoundException ignored) {
+        // -@cs[IllegalCatch] Exception type is not predictable.
+        catch (final Exception ignored) {
             clazz = null;
         }
         return clazz;