Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

power_deviation_matrix_configuration.py getBin does not use binning.Bins Class #200

Open
Speters1086 opened this issue May 3, 2018 · 0 comments
Open

power_deviation_matrix_configuration.py getBin does not use binning.Bins Class #200

Speters1086 opened this issue May 3, 2018 · 0 comments

Comments

@Speters1086
Copy link

This is inconsistent with the Binning Class structure and is confusing.

def getBin(self, dimension, value): return round(round((value - dimension.centerOfFirstBin) / dimension.binWidth, 0) * dimension.binWidth + dimension.centerOfFirstBin, 4)

This should use the binning.Bins Class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Speters1086