Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial: Chapter 1.1 - SwiftUI / Building a Simple Todo List UI #94

Conversation

peterfriese
Copy link
Owner

@peterfriese peterfriese commented Mar 9, 2023

Signed-off-by: Peter Friese <peter@peterfriese.de>
Signed-off-by: Peter Friese <peter@peterfriese.de>
Signed-off-by: Peter Friese <peter@peterfriese.de>
Signed-off-by: Peter Friese <peter@peterfriese.de>
Signed-off-by: Peter Friese <peter@peterfriese.de>
Signed-off-by: Peter Friese <peter@peterfriese.de>
@peterfriese peterfriese added the tutorial Interactive DocC tutorial label Mar 9, 2023
@peterfriese peterfriese marked this pull request as ready for review March 9, 2023 17:00
@peterfriese peterfriese self-assigned this Mar 9, 2023
Signed-off-by: Peter Friese <peter@peterfriese.de>
@marinacoelho
Copy link
Collaborator

This is great! I did all the steps in the tutorial, and the code works flawlessly.
Love the diagrams, the gifs, and the focus on user experience (the FocusableField step is very nice and well explained).
On another note, I noticed that a few Sections don't have the header image - is this something I can help you with?

Copy link
Collaborator

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff @peterfriese! Pretty much all of the feedback I left is optional. I'm sure it's a lot of work to even rename APIs given the multiple code snippets, screenshots, and tutorial writeup so I'll leave it up to you to decide if a suggestion is worth implementing. 🙂

peterfriese and others added 5 commits March 13, 2023 18:10
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
Signed-off-by: Peter Friese <peter@peterfriese.de>
Signed-off-by: Peter Friese <peter@peterfriese.de>
@peterfriese
Copy link
Owner Author

This is great! I did all the steps in the tutorial, and the code works flawlessly. Love the diagrams, the gifs, and the focus on user experience (the FocusableField step is very nice and well explained). On another note, I noticed that a few Sections don't have the header image - is this something I can help you with?

Thanks for the review! I added all of the missing images, and it looks much better now :-)

@peterfriese
Copy link
Owner Author

Awesome stuff @peterfriese! Pretty much all of the feedback I left is optional. I'm sure it's a lot of work to even rename APIs given the multiple code snippets, screenshots, and tutorial writeup so I'll leave it up to you to decide if a suggestion is worth implementing. 🙂

Thanks for the review! It was less work to make those changes than I expected.

@peterfriese peterfriese merged commit b2a71eb into tutorial/main Mar 13, 2023
@peterfriese peterfriese deleted the tutorial/develop/01-swiftui/01-building-a-simple-todo-list-ui branch March 13, 2023 18:49
@peterfriese peterfriese restored the tutorial/develop/01-swiftui/01-building-a-simple-todo-list-ui branch May 17, 2023 13:51
@peterfriese peterfriese changed the title Tutorial: SwiftUI / Building a Simple Todo List UI Tutorial: Chapter 1.1 - SwiftUI / Building a Simple Todo List UI May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tutorial Interactive DocC tutorial
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants