Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

down_retry_delay default is too low #621

Closed
mrsimo opened this issue May 23, 2016 · 1 comment
Closed

down_retry_delay default is too low #621

mrsimo opened this issue May 23, 2016 · 1 comment
Milestone

Comments

@mrsimo
Copy link

mrsimo commented May 23, 2016

Hi there! We were running some tests to figure out how much memcached downtime could handle our app, and since that downtime, we've gotten a bit familiar with down_retry_delay.

The default value for this value is 1s, but coupled with a socket_max_failures of 2, and a socket_timeout of 0.5, I think that makes the default for down_retry_delay not very good.

If the memcached server is down in a way that we exhaust the socket_timeout, considering the retries it does, down_retry_delay doesn't ever do anything.

Stopping one of our memcached servers caused all memcached queries to it to take 1s, which slowed our unicorns to a point where we ran out of them.

We changed the value of down_retry_delay to 120s, and now memcached servers going down doesn't have any visible effects.

I would suggest changing the default of this value to something bigger.

@petergoldstein petergoldstein added this to the 3.0 milestone Jan 14, 2017
jaredhales added a commit to jaredhales/dalli that referenced this issue Mar 8, 2017
I ran into this myself recently. I saw the existing issue and figured I’d throw together a quick pull request since nobody had done anything with this since it was raised back in May of last year.
@petergoldstein
Copy link
Owner

Fixed by #650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants