Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed "uninitialized constant Rack::Session::Dalli::Client" #151

Merged
merged 1 commit into from Dec 12, 2011

Conversation

blakedy
Copy link
Contributor

@blakedy blakedy commented Dec 12, 2011

Just started using Dalli. Found you guys through Heroku Memcache recommendation. Like what you guys are doing. Needed Rack::Session::Dalli as well, fixed line 17.

mperham added a commit that referenced this pull request Dec 12, 2011
fixed "uninitialized constant Rack::Session::Dalli::Client"
@mperham mperham merged commit 8505c67 into petergoldstein:master Dec 12, 2011
@mperham
Copy link
Collaborator

mperham commented Dec 12, 2011

Thanks!

@blakedy
Copy link
Contributor Author

blakedy commented Dec 12, 2011

Also,

mopts = @default_options.reject{|k,v| !DEFAULT_OPTIONS.include? k }

removes username and password if passing it with Rack::Session::Dalli

I updated my fork to append username and password to DEFAULT_OPTIONS

DEFAULT_OPTIONS = Abstract::ID::DEFAULT_OPTIONS.merge
:namespace => 'rack:session',
:memcache_server => 'localhost:11211',
:username => nil,
:password => nil,

potentially other option maybe rejected

@mperham
Copy link
Collaborator

mperham commented Dec 14, 2011

Why would you pass username / password? 99.9% of Dalli usage with user/pwd is on Heroku and that is handled automatically for you by environment variables.

Could you send me a new pull request to pull in those changes too? Obviously I need to write a test for this thing. It would be a huge help if you want to create a test based on your usage as I haven't had to use it yet.

@blakedy
Copy link
Contributor Author

blakedy commented Dec 14, 2011

You're right. I added usr/pwd for development reasons. I've reverted and updated my ENV variables for development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants