Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use assert_nil in tests #661

Closed
wants to merge 1 commit into from
Closed

Use assert_nil in tests #661

wants to merge 1 commit into from

Conversation

pvalena
Copy link

@pvalena pvalena commented Aug 22, 2017

instead of assert_equal nil, because it produces errors with activesupport >= 5.1.3.

@pvalena
Use assert_nil in tests
6d3243e 
instead of `assert_equal nil`, because it produces errors with activesupport >= 5.1.3.
@petergoldstein
Copy link
Owner

@pvalena Thanks for the contribution. Would up inadvertently duplicating this in PR #665 . So I'm closing this PR.

@pvalena pvalena deleted the assert_nil branch February 26, 2018 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pvalena @petergoldstein