Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move check whether TCPSocket was patched to TCP.open #991

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Move check whether TCPSocket was patched to TCP.open #991

merged 1 commit into from
Feb 7, 2024

Conversation

y9v
Copy link
Contributor

@y9v y9v commented Feb 6, 2024

This is a follow-up for #987.

We cannot check if resolv-replace changed TCPSocket#initialize method, since we have no guarantee that resolv-replace will be required before dalli. This PR moves this check to TCP.open method.

@y9v y9v mentioned this pull request Feb 6, 2024
Closed
@petergoldstein petergoldstein merged commit d5ad58f into petergoldstein:main Feb 7, 2024
21 checks passed
@petergoldstein
Copy link
Owner

Thanks!

@y9v y9v mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@y9v @petergoldstein