Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ginkgo_compatible package does not export certain matchers #80

Closed
astefanova opened this issue Mar 5, 2019 · 2 comments
Closed

ginkgo_compatible package does not export certain matchers #80

astefanova opened this issue Mar 5, 2019 · 2 comments
Labels
bug

Comments

@astefanova
Copy link

Hello,

ginkgo_compatible package does not export certain matchers, like: invocation count matchers (Once, Twice, etc.) and InOrderContext.

Is that on purpose? Or could we make a PR exporting those?

Kind regards,
Adriana
@petergtz
Copy link
Owner

petergtz commented Mar 5, 2019

Hi @astefanova,

That's definitely not on purpose. I must have forgotten it. A PR is more than welcome! Thank you!

Peter

@petergtz petergtz added the bug label Mar 5, 2019
petergtz added a commit that referenced this issue Jun 24, 2019
@petergtz
Add missing matcher and InOrderContext to ginkgo_compatible
f9ca664 
#80
@petergtz
Copy link
Owner

@astefanova I've finally got around to do it myself. In case this is still interesting to you, it's on latest develop. Will merge it to master and make a new release soon.

petergtz added a commit that referenced this issue Oct 16, 2019
@petergtz
Add missing matcher and InOrderContext to ginkgo_compatible
afa3ae7 
#80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petergtz @astefanova