-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paste input not displayed after #81 was fixed #86
Comments
tsandall
added a commit
to tsandall/opa
that referenced
this issue
Jan 18, 2017
Temporarily resolving peterh/liner#86
tsandall
added a commit
to open-policy-agent/opa
that referenced
this issue
Jan 18, 2017
Temporarily resolving peterh/liner#86
peterh
added a commit
that referenced
this issue
Feb 11, 2017
Sorry for the slow reply. I was away when your bug report came in, and I forgot about it when I got back. I wasn't able to reproduce this bug, but I think I see how it happens. I just pushed a change that should fix it. Could you please test bf27d3b and let me know? Thanks. |
Updated to bf27d3b and did not see the problem. LGTM. |
Great! Thanks for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello! First of all, thanks for making a great library. I've been happily building a REPL on top of it for a little while now.
Description
Recently, I noticed an issue when pasting text containing newlines into the REPL. Specifically, liner doesn't display the pasted text, however, it seems that liner has received the text and passed it to the REPL.
I only noticed this after recently updating to the tip of master. I manually bisected the history and found that the behaviour changed with 2d7c636 (which fixed #81).
Steps to reproduce
It may be a bit tricky to reproduce this bug in isolation. The key (in my case) seems to be pasting text containing newlines. If the text doesn't contain a newline, it displays fine.
I can offer you a working example (on Mac):
Note: the paste happens on the first non-empty line after "Run 'help' to see [...]", i.e., "> p :- true".
When I do the same with openpolicyagent/opa:0.2.2, I only see an empty line:
In v0.2.1 OPA is using 8975875 and in v0.2.2 OPA is using 3c5f577. This is what I get for not pinning dependencies with Glide.
Additional Info
The text was updated successfully, but these errors were encountered: