Fix for #98 #101
Merged
Fix for #98 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filimonov
changed the title
|
Now there are issues in multiline mode on the end of the screen. I will try do git it deeper. UPD: hmm... heisenbug. Yesterday i suddenly start getting problems with cursor placement on Windows. Today (the same binary, under the same conditions) - everything works properly. May be some misbehaviour of windows console itself? |
|
Thanks for the patch. Heisenbug or not, I like the approach of incrementing the calculated length instead of decrementing the detected width, so I pulled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the approach of fixing #71
(introduced by 0e4af13).
Instead of 'decreasing' screen width for cases when cursor take extra column, increment the calculated user input length.
With correct screen width multiline mode works properly.