Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dropdown logic to use a store #47

Closed
peterhil opened this issue Jun 3, 2021 · 0 comments
Closed

Fix dropdown logic to use a store #47

peterhil opened this issue Jun 3, 2021 · 0 comments
Assignees
@peterhil
Labels
prio: incremental Low effort, low impact technical
Projects
Svelte stores Code cleanup
Milestone
0.5.0

Comments

@peterhil
Copy link
Owner

peterhil commented Jun 3, 2021

Dropdown visibility logic is currently very cumbersome. It would greatly benefit from using Svelte store for state management.
@peterhil peterhil created this issue from a note in Svelte stores (To do) Jun 3, 2021
@peterhil peterhil self-assigned this Jun 3, 2021
@peterhil peterhil added this to To do in Code cleanup Jun 11, 2021
@peterhil peterhil mentioned this issue Jun 11, 2021
Open
4 tasks
@peterhil peterhil added this to the 0.5.0 milestone Jun 11, 2021
@peterhil peterhil added the prio: incremental Low effort, low impact label Jun 11, 2021
@peterhil peterhil modified the milestones: 0.5.0, 0.4.3 Jun 17, 2021
@peterhil peterhil mentioned this issue Jun 18, 2021
Closed
6 tasks
@peterhil peterhil moved this from To do to In progress in Code cleanup Jun 18, 2021
peterhil added a commit that referenced this issue Jun 18, 2021
@peterhil
Rename dropdownStore as dropdownShown and move it to separate file #47
3e27c10
peterhil added a commit that referenced this issue Jun 18, 2021
@peterhil
Remove unused reactive variables from CategorySelector #47
1de2887
peterhil added a commit that referenced this issue Jun 18, 2021
@peterhil
Cleanup isVisible on CategorySelector #47
5ee6975
peterhil added a commit that referenced this issue Jun 18, 2021
@peterhil
Remove unused reactive variable categories from CategorySelector #47
5984556
peterhil added a commit that referenced this issue Jun 18, 2021
@peterhil
Move stores up from lib #47
ceab339
peterhil added a commit that referenced this issue Jun 18, 2021
@peterhil
Move currentTab store into stores/currentTab.js #47
0f11120
peterhil added a commit that referenced this issue Jun 18, 2021
@peterhil
Rename selectionStore as categorySelection #47
b1a9d91
peterhil added a commit that referenced this issue Jun 18, 2021
@peterhil
Use categorySelection store on CategorySelector #47
ef8426c
peterhil added a commit that referenced this issue Jun 18, 2021
@peterhil
Change icons for child and recent category dropdown toggles #47
3edbff2
Svelte stores automation moved this from To do to Done Jun 20, 2021
Code cleanup automation moved this from In progress to Done Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterhil peterhil

Labels
prio: incremental Low effort, low impact technical
Projects
Svelte stores
Done
Code cleanup
Done
Code cleanup
Status: Done
Milestone
0.5.0
Development

No branches or pull requests
1 participant
@peterhil