Conversation
I think we need to feature-gate the change to remove Before this change:
With this change:
|
@peterhuene The code changes should be well set up to handle feature gating. I tried using I'll get something working before we merge |
63a724d
to
ad2b412
Compare
@peterhuene This is ready to go I believe. I think the next thing to do is to change the generated cargo project to have a |
Thanks @rylev! I'll review this in-depth tonight and hopefully get it merged. I can update the |
@rylev can you rebase and possibly squash? I should have held off on merging in the dependency updates, sorry about that. |
7d563a4
to
1d3fb1d
Compare
acbbfd7
to
22fead0
Compare
), | ||
}) | ||
.emit(); | ||
let foo = match s.value().as_ref() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
foo
is a placeholder name that generates a warning for clippy.
Perhaps message
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops. How embarrassing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a few feedback changes to make. Awesome work!
No description provided.