Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency loop on community SailfishOS #8

Open
DrYak opened this issue Oct 27, 2023 · 2 comments
Open

Dependency loop on community SailfishOS #8

DrYak opened this issue Oct 27, 2023 · 2 comments

Comments

@DrYak
Copy link

DrYak commented Oct 27, 2023

Currently running Defender on SFOS Community edition on a PinePhone Pro and this dependency loop happens:

  • basic.targets depends on ...
  • paths.target which depends on ...
  • harbour-defender.path which depends on ..
  • home and unlocking home and all these things
  • which in turn depend on basic targets.

The recent systemd version in that SFOS version is actually able to detect the circular dependency, and solves it...
...by removing paths.target.

My suggestion would be to add DefaultDependencies=no in harbour's paths' units.
This way harbour's paths are started as part of paths.target, but there is no implicit "After=" in the target, thus it breaks the circular dependency, while the path is still scheduled for restart.

I'll make a PR.
DrYak added a commit to DrYak/harbour-defender that referenced this issue Oct 27, 2023
@DrYak
Support SFOS Community port
877d008 
- fixes issue peterleinchen#8 : cyclic dependency in base.target that causes paths.target to be removed
  - `DefaultDependencies=no` remove the implicit `After=` in paths.target
- the community encryption unlocker is a different service (decrypt-home_encrypted.service)
@DrYak DrYak mentioned this issue Oct 27, 2023
Open
@DrYak
Copy link
Author

DrYak commented Oct 27, 2023

PR is available here: #9

@DrYak
Copy link
Author

DrYak commented Oct 27, 2023

The exact error message is:

basic.target: Job paths.target/start deleted to break ordering cycle starting with basic.target/start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DrYak