Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented book search and pagination #56

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Implemented book search and pagination #56

merged 1 commit into from
Aug 30, 2021

Conversation

petermcd
Copy link
Owner

No description provided.

@petermcd petermcd added the enhancement New feature or request label Aug 30, 2021
@petermcd petermcd self-assigned this Aug 30, 2021
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 30, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 6.31%.

Quality metrics Before After Change
Complexity 0.00 ⭐ 0.60 ⭐ 0.60 👎
Method Length 8.75 ⭐ 15.50 ⭐ 6.75 👎
Working memory 2.33 ⭐ 4.00 ⭐ 1.67 👎
Quality 99.89% 93.58% -6.31% 👎
Other metrics Before After Change
Lines 9 13 4
Changed files Quality Before Quality After Quality Change
books/views.py 99.89% ⭐ 93.58% ⭐ -6.31% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@petermcd petermcd merged commit c777261 into main Aug 30, 2021
@petermcd petermcd deleted the book-enhancements branch August 30, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant