Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated redirect url #84

Merged
merged 12 commits into from
Dec 23, 2021
Merged

updated redirect url #84

merged 12 commits into from
Dec 23, 2021

Conversation

petermcd
Copy link
Owner

No description provided.

@petermcd petermcd self-assigned this Dec 23, 2021
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 23, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.82 ⭐ 1.82 ⭐ 0.00
Method Length 29.61 ⭐ 29.61 ⭐ 0.00
Working memory 7.20 🙂 7.20 🙂 0.00
Quality 80.34% 80.34% 0.00%
Other metrics Before After Change
Lines 357 357 0
Changed files Quality Before Quality After Quality Change
monzo_hourly_transactions.py 100.00% ⭐ 100.00% ⭐ 0.00%
monzo_load_merchants.py 100.00% ⭐ 100.00% ⭐ 0.00%
monzo_monthly_interest.py 100.00% ⭐ 100.00% ⭐ 0.00%
finance/admin.py 91.52% ⭐ 91.52% ⭐ 0.00%
finance/models.py 91.37% ⭐ 91.37% ⭐ 0.00%
finance/monzo_automation.py 73.43% 🙂 73.43% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
finance/monzo_automation.py MonzoAutomation.process_transactions 5 ⭐ 118 🙂 11 😞 59.77% 🙂 Extract out complex expressions
finance/monzo_automation.py MonzoAutomation._process_transaction 5 ⭐ 94 🙂 10 😞 64.87% 🙂 Extract out complex expressions
finance/monzo_automation.py MonzoAutomation.update_interest 1 ⭐ 89 🙂 10 😞 69.55% 🙂 Extract out complex expressions
finance/monzo_automation.py MonzoAutomation.__init__ 0 ⭐ 45 ⭐ 10 😞 77.29% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@petermcd petermcd merged commit 1b95210 into main Dec 23, 2021
@petermcd petermcd added the bug Something isn't working label Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant