Skip to content

Commit

Permalink
build: yarnrc --ignore-engines true
Browse files Browse the repository at this point in the history
Specifies the --ignore-engines true parameter to be the default for
every yarn command contributors run within the project. This makes it
sligthly more convenient to work with yarn since now you can just say
"yarn install" instead of having to go with the much longer "yarn
install --ignore-engines". Of course in an ideal world we would not need
the --ignore-engines parameter but the Fabric Node SDK (and some other
dependencies probably) do not declare NodeJS v16 as a supported engine
(despite our tests succeeding on these) so we just do not have a choice
with this if we want to support NodeJS 16 (which we very much
do)\n\nAlso removes --ignore-engines parameter from the yarn install
command that the configure script runs so that the CI also verifies this
to be working fine.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
  • Loading branch information
petermetz committed Aug 4, 2021
1 parent e6aea32 commit b0688e8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .yarnrc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
# yarn lockfile v1


--ignore-engines true

lastUpdateCheck 1626930910805
yarn-path ".yarn/releases/yarn-1.19.0.js"
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
],
"scripts": {
"run-ci": "./tools/ci.sh",
"configure": "yarn install --frozen-lockfile --non-interactive --ignore-engines && yarn run build:dev:backend",
"configure": "yarn install --frozen-lockfile --non-interactive && yarn run build:dev:backend",
"install-yarn": "npm install --global yarn@1.19.0",
"custom-checks": "ts-node ./tools/custom-checks/run-custom-checks.ts",
"generate-api-server-config": "node ./tools/generate-api-server-config.js",
Expand Down

0 comments on commit b0688e8

Please sign in to comment.