Skip to content

Commit

Permalink
add Benchmark (benchmarkjs) benchmark result for ec8123c
Browse files Browse the repository at this point in the history
  • Loading branch information
github-action-benchmark committed Jun 12, 2024
1 parent 2bbcb09 commit ea8eed8
Showing 1 changed file with 32 additions and 1 deletion.
33 changes: 32 additions & 1 deletion dev/bench/data.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
window.BENCHMARK_DATA = {
"lastUpdate": 1718219974461,
"lastUpdate": 1718220798429,
"repoUrl": "https://github.com/petermetz/cacti",
"entries": {
"Benchmark": [
Expand Down Expand Up @@ -254,6 +254,37 @@ window.BENCHMARK_DATA = {
"extra": "180 samples"
}
]
},
{
"commit": {
"author": {
"email": "peter.somogyvari@accenture.com",
"name": "Peter Somogyvari",
"username": "petermetz"
},
"committer": {
"email": "petermetz@users.noreply.github.com",
"name": "Peter Somogyvari",
"username": "petermetz"
},
"distinct": false,
"id": "ec8123cf954b09ba8cb213c7332dfe82224c351f",
"message": "feat(connector-fabric): drop support for Fabric v1.x\n\nBREAKING CHANGE: The Open API specification that has the enums for\nledger versions will no longer have an option for Fabric v1.x\nThis means that in the core-api package the LedgerType enum has changes\nwhich means that code that depends on that enum value will need to be\nupdated.\n\nFabric v1.x has had unmaintained dependencies associated with it such as\nthe native grpc package that stopped receiving security updates years ago\nand therefore it's dangerous to have around.\n\nThere are also some issues with Fabric v1.x that make the AIO image flaky\nwhich also makes the relevant tests flaky due to which we couldn't run\nthe v1.x Fabric tests on the CI for a while now anyway.\n\nIn order to reduce the CI resource usage and our own maintenance burden\nI suggest that we get rid of the Fabric v1.x support meaning that we can\neliminate the AIO image build and some code complexity from the test ledger\ncode as well.\n\nIn addition some old fixtures can be removed that the tests were using.\nOverall a net-positive as deleting code without losing functionality (that\nwe care about) is always a plus.\n\nSigned-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>",
"timestamp": "2024-06-12T11:12:42-07:00",
"tree_id": "cfaf922e1ca373842ba7d01f923a3ad75d880f8a",
"url": "https://github.com/petermetz/cacti/commit/ec8123cf954b09ba8cb213c7332dfe82224c351f"
},
"date": 1718220795848,
"tool": "benchmarkjs",
"benches": [
{
"name": "plugin-ledger-connector-besu_HTTP_GET_getOpenApiSpecV1",
"value": 759,
"range": "±3.00%",
"unit": "ops/sec",
"extra": "180 samples"
}
]
}
]
}
Expand Down

0 comments on commit ea8eed8

Please sign in to comment.