Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

" " issue #12

Closed
jforaker opened this issue Mar 24, 2017 · 4 comments
Closed

" " issue #12

jforaker opened this issue Mar 24, 2017 · 4 comments

Comments

@jforaker
Copy link

jforaker commented Mar 24, 2017

non breaking spaces are rendered as a string  

for example, paste this block into the demo site:

<p><span>He had a stark message for Republicans when they met today about his bill to repeal Obamacare: Vote for the bill, or you could&nbsp;</span><a class="markup--anchor markup--li-anchor" href="#">lose re-election</a><span>.</span></p>

You will see the &nbsp;'s actually get rendered. Pasting the same block into Codepen/JSBin renders the space properly as expected.

Expected: &nbsp; should render a space

@real34
Copy link

real34 commented Apr 19, 2017

Same thing for other html special chars (&eacute; ...)

@jforaker
Copy link
Author

Well it looks like the actual parsing happens with https://github.com/fb55/htmlparser2 under the hood. However, there doesn't seem to be any open issues there regarding the &nbsp; issue. Hard to tell where the issue happens. And its been about a year since @wrakky 's last commit. Maybe a sign to look elsewhere.

@rmccue
Copy link

rmccue commented Jun 7, 2017

Fixed this in #14; it just needs an extra flag passed to htmlparser2.

@peternewnham
Copy link
Owner

This will be fixed in next release thanks to #14 and #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants