Added react 17 and 18, in peer dependency and fixed version for 14 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pr is related to #84 issue. @mjj2000 @peternewnham @kevinzwhuang |
Jer512
approved these changes
Feb 28, 2023
|
Ready when you are! |
|
@hamidnawaz28 please merge this pr. |
|
@ravneetsinghgaba I can't merge it, the owner can |
|
Is this library still maintained by someone? Is it possible to fork and publish to npm? Has anyone done that already to bring peer dependency to React 17.x and 18.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #84, where we are required the peerDependency of react for version 14,15 and 16. React is currently on version 18, so I have added version 17 and 18 to the peer dependency.