Modify the getDynamicOnBehalfOfSettings() to return settings.Empty if…

… there is no changes Signed-off-by: Ryan Liang <jiallian@amazon.com>
peternied · Aug 22, 2023 · a4efad6 · a4efad6
1 parent e23d757
commit a4efad6
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/src/main/java/org/opensearch/security/action/onbehalf/CreateOnBehalfOfTokenAction.java b/src/main/java/org/opensearch/security/action/onbehalf/CreateOnBehalfOfTokenAction.java
@@ -61,16 +61,13 @@ public void onDynamicConfigModelChanged(DynamicConfigModel dcm) {
         this.dcm = dcm;
 
         Settings settings = dcm.getDynamicOnBehalfOfSettings();
-        if (settings != null) {
-            Boolean enabled = Boolean.parseBoolean(settings.get("enabled"));
-            String signingKey = settings.get("signing_key");
-            String encryptionKey = settings.get("encryption_key");
-
-            if (!Boolean.FALSE.equals(enabled) && signingKey != null && encryptionKey != null) {
-                this.vendor = new JwtVendor(settings, Optional.empty());
-            } else {
-                this.vendor = null;
-            }
+
+        Boolean enabled = Boolean.parseBoolean(settings.get("enabled"));
+        String signingKey = settings.get("signing_key");
+        String encryptionKey = settings.get("encryption_key");
+
+        if (!Boolean.FALSE.equals(enabled) && signingKey != null && encryptionKey != null) {
+            this.vendor = new JwtVendor(settings, Optional.empty());
         } else {
             this.vendor = null;
         }