Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mimemagic and other gems #1002

Merged
merged 1 commit into from Mar 24, 2021
Merged

Update mimemagic and other gems #1002

merged 1 commit into from Mar 24, 2021

Conversation

miharekar
Copy link
Contributor

Resolves this shit show:

Description

This is the actual issue mimemagicrb/mimemagic#97

Reviewer Checklist

  • PR has a clear title and description
  • Manually tested the changes that the PR introduces
  • Changes introduced by the PR are covered by tests of acceptable quality
  • Checked the quality of commit messages

thomascullen
thomascullen approved these changes Mar 24, 2021
View reviewed changes
Copy link
Collaborator

@thomascullen thomascullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@miharekar miharekar merged commit e56b661 into master Mar 24, 2021
@miharekar miharekar deleted the mimemagick-kerfuffle branch March 24, 2021 14:28
@miharekar miharekar mentioned this pull request Mar 29, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomascullen thomascullen thomascullen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miharekar @thomascullen