Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow dom #14

Closed
peterpeterparker opened this issue Feb 2, 2019 · 6 comments
Closed

Shadow dom #14

peterpeterparker opened this issue Feb 2, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@peterpeterparker
Copy link
Owner

Currently this Web Component isn't shadowed. As I spend several times developing such components recently I'm thinking about migrating this Web Component to a shadowed one.

Reason is also that I noticed yesterday some problems when a none shadowed components would be use in other shadowed components.

Finally, as recently <slot/> have been added, these could become the main way to inject actions icon.

Probably something I could develop when I'll implement it DeckDeckGo deckgo/starter-kit#30

@peterpeterparker peterpeterparker added the enhancement New feature or request label Feb 2, 2019
@peterpeterparker
Copy link
Owner Author

peterpeterparker commented Feb 2, 2019

@fmendoza @abennouna any thoughts or would that be a problem for you?

@abennouna
Copy link

Nothing that I can think of. Will be glad to upgrade or test!

@fmendoza
Copy link
Contributor

fmendoza commented Feb 2, 2019

Will we have the ability to style the slotted elements from the outside?

@peterpeterparker
Copy link
Owner Author

@fmendoza I think so, I just read an article about it...which I actually wrote 😂😂😂

https://medium.com/stencil-tricks/a-practical-introduction-to-styling-a-shadow-dom-and-slots-879565a2f423 (chapter "styling slots")

so yep last time I tried out you could style slot from outside, I'll keep that in mind when I'll try to develop this, cool?

@fmendoza
Copy link
Contributor

fmendoza commented Feb 2, 2019

What a great post. Crystal.

Go shadow 😎

@peterpeterparker
Copy link
Owner Author

@fmendoza @abennouna FYI, it has been release in v5.0.0

this Web Component is now shadowed

https://github.com/fluster/web-social-share/releases/tag/v5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants