Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move slots not compatible with Font Awesome CSS #18

Closed
peterpeterparker opened this issue Jul 29, 2019 · 0 comments
Closed

Move slots not compatible with Font Awesome CSS #18

peterpeterparker opened this issue Jul 29, 2019 · 0 comments
Assignees
@peterpeterparker
Labels
bug Something isn't working

Comments

@peterpeterparker
Copy link
Owner

The fact that slots are move by the component from parent (web-social-share) to children (web-social-share-target) is not compatible with Font Awesome CSS

Doing so, CSS style from Font Awesome won't be applied and therefore no icons are going to be displayed

Possible solution:

  • Refactor: get rid of web-social-share-target and don't move slots
  • Breaking change: ask users to use web-social-share-target to include slots

=> Refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterpeterparker peterpeterparker

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterpeterparker