Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pseudo slots to the social share actions #8

Closed
peterpeterparker opened this issue Jan 26, 2019 · 1 comment
Closed

Add pseudo slots to the social share actions #8

peterpeterparker opened this issue Jan 26, 2019 · 1 comment
Assignees
@peterpeterparker
Labels
enhancement New feature or request

Comments

@peterpeterparker
Copy link
Owner

peterpeterparker commented Jan 26, 2019 •
edited

Adding <slot/> to each social share actions would let developers pass more complex styling or elements to the share actions than just styling with css, like for example passing an Ionic icon

As the component isn't shadowed, the slots are mostly use as selector
@peterpeterparker peterpeterparker added the enhancement New feature or request label Jan 26, 2019
@peterpeterparker peterpeterparker self-assigned this Jan 26, 2019
@peterpeterparker peterpeterparker changed the title Add slots to the social share actions Add pseudo slots to the social share actions Jan 26, 2019
peterpeterparker added a commit that referenced this issue Jan 26, 2019
@peterpeterparker
feat(#8): add slots to inject customized icons or content
04afe37
peterpeterparker added a commit that referenced this issue Jan 26, 2019
@peterpeterparker
doc(#8): slots
977aa26
@peterpeterparker
Copy link
Owner Author

Released in v3.0.0

Thx @abennouna for the idea 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterpeterparker peterpeterparker

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterpeterparker