Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Incorrect URL when socialShareText is empty (Whatsapp) #13

Merged

Conversation

fmendoza
Copy link
Contributor

@fmendoza fmendoza commented Feb 2, 2019

No description provided.

@fmendoza
Copy link
Contributor Author

fmendoza commented Feb 2, 2019

My current workaround:

whatsapp: {
  socialShareText: ' ',
  socialShareUrl: 'https://websocialshare.com',
}

Didn't like it so here's my pull request :)

@peterpeterparker peterpeterparker merged commit f5b03dd into peterpeterparker:master Feb 2, 2019
@peterpeterparker
Copy link
Owner

super cool @fmendoza thx a lot for the PR 👍

merged and released in v4.0.2

@fmendoza fmendoza deleted the fmendoza-whatsapp-patch-1 branch February 2, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants